md: don't clear MD_RECOVERY_FROZEN for new dm-raid until resume

[ Upstream commit 2f03d0c2cd451c7ac2f317079d4ec518f0986b55 ]

After commit 9dbd1aa3a81c ("dm raid: add reshaping support to the
target") raid_ctr() will set MD_RECOVERY_FROZEN before md_run() and
expect to keep array frozen until resume. However, md_run() will clear
the flag by setting mddev->recovery to 0.

Before commit 1baae052cccd ("md: Don't ignore suspended array in
md_check_recovery()"), dm-raid actually relied on suspending to prevent
starting new sync_thread.

Fix this problem by keeping 'MD_RECOVERY_FROZEN' for dm-raid in
md_run().

Fixes: 1baae052cccd ("md: Don't ignore suspended array in md_check_recovery()")
Fixes: 9dbd1aa3a81c ("dm raid: add reshaping support to the target")
Cc: stable@vger.kernel.org # v6.7+
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Xiao Ni <xni@redhat.com>
Acked-by: Mike Snitzer <snitzer@kernel.org>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20240305072306.2562024-2-yukuai1@huaweicloud.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 40dea4c06457fb064b66c54f0c15186fd7d52ad7..007fd071b44ed745bf429578a5b89cc6bd9cf67a 100644 (file)
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -6064,7 +6064,10 @@ int md_run(struct mddev *mddev)
                        pr_warn("True protection against single-disk failure might be compromised.\n");
        }
 
-       mddev->recovery = 0;
+       /* dm-raid expect sync_thread to be frozen until resume */
+       if (mddev->gendisk)
+               mddev->recovery = 0;
+
        /* may be over-ridden by personality */
        mddev->resync_max_sectors = mddev->dev_sectors;