]> git.ipfire.org Git - thirdparty/libnftnl.git/commitdiff
expr: match: Use nft_rule_expr_set_* in the xml parsing code
authorAna Rey <anarey@gmail.com>
Tue, 24 Jun 2014 17:15:02 +0000 (19:15 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 24 Jun 2014 17:18:59 +0000 (19:18 +0200)
Code refactoring to use nft_rule_expr_set_* in parse functions.

Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/expr/match.c

index 05f9affbf96e44b70a5b9ae665344eb688ba75c9..572d0f95caad78098e1043c532bda6b36d41545e 100644 (file)
@@ -194,17 +194,13 @@ static int nft_rule_expr_match_xml_parse(struct nft_rule_expr *e, mxml_node_t *t
                                         struct nft_parse_err *err)
 {
 #ifdef XML_PARSING
-       struct nft_expr_match *mt = nft_expr_data(e);
        const char *name;
 
        name = nft_mxml_str_parse(tree, "name", MXML_DESCEND_FIRST,
                                  NFT_XML_MAND, err);
        if (name == NULL)
                return -1;
-
-       strncpy(mt->name, name, XT_EXTENSION_MAXNAMELEN);
-       mt->name[XT_EXTENSION_MAXNAMELEN-1] = '\0';
-       e->flags |= (1 << NFT_EXPR_MT_NAME);
+       nft_rule_expr_set_str(e, NFT_EXPR_MT_NAME, name);
 
        /* mt->info is ignored until other solution is reached */