]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
cpu_x86: Simplify x86DataAdd
authorJiri Denemark <jdenemar@redhat.com>
Fri, 15 Mar 2019 15:37:28 +0000 (16:37 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Fri, 12 Apr 2019 20:53:39 +0000 (22:53 +0200)
The while loop just copied half of virCPUx86DataAddItem.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/cpu/cpu_x86.c

index 121c88ad43f7af3aca6e4515e6a2a1bbc488e7d8..41067617df67c6dfa5d6fd2ea43c67877bc3aead 100644 (file)
@@ -405,18 +405,11 @@ x86DataAdd(virCPUx86Data *data1,
            const virCPUx86Data *data2)
 {
     virCPUx86DataIterator iter = virCPUx86DataIteratorInit(data2);
-    virCPUx86DataItemPtr item1;
-    virCPUx86DataItemPtr item2;
-
-    while ((item2 = virCPUx86DataNext(&iter))) {
-        item1 = virCPUx86DataGet(data1, item2);
+    virCPUx86DataItemPtr item;
 
-        if (item1) {
-            x86cpuidSetBits(&item1->cpuid, &item2->cpuid);
-        } else {
-            if (virCPUx86DataAddItem(data1, item2) < 0)
-                return -1;
-        }
+    while ((item = virCPUx86DataNext(&iter))) {
+        if (virCPUx86DataAddItem(data1, item) < 0)
+            return -1;
     }
 
     return 0;