]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
test_driver: Don't report VIR_DOMAIN_DISK_ERROR_NONE
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 14 May 2019 15:09:19 +0000 (17:09 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 3 Jul 2019 07:06:41 +0000 (09:06 +0200)
In my review of 89320788ac4 I've simplified assigning disk errors
too much as the code I've changed it to will set
VIR_DOMAIN_DISK_ERROR_NONE. This is in contradiction with our
documentation which specifies that disks with no errors are not
reported.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/test/test_driver.c

index e3545e70857257d1b238f924351af4ffb5f109d0..84de8059eadfd715cdca26c1559b12caac21c433 100644 (file)
@@ -3277,7 +3277,7 @@ static int testDomainGetDiskErrors(virDomainPtr dom,
         for (i = 0; i < MIN(vm->def->ndisks, maxerrors); i++) {
             if (VIR_STRDUP(errors[i].disk, vm->def->disks[i]->dst) < 0)
                 goto cleanup;
-            errors[i].error = i % VIR_DOMAIN_DISK_ERROR_LAST;
+            errors[i].error = (i % (VIR_DOMAIN_DISK_ERROR_LAST - 1)) + 1;
         }
         ret = i;
     } else {