]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: iwlwifi: mld: remove support for REDUCE_TX_POWER_CMD ver 9
authorMiri Korenblit <miriam.rachel.korenblit@intel.com>
Fri, 11 Jul 2025 15:34:20 +0000 (18:34 +0300)
committerMiri Korenblit <miriam.rachel.korenblit@intel.com>
Mon, 14 Jul 2025 16:36:13 +0000 (19:36 +0300)
iwlmld was planned to be used for HR, which has version 9,
but it was decided at the end to use iwlmvm for HR, so iwlmld only
needs to support version 10.
Remove version 9 support.

Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250711183056.aeeb617abfae.I05101972506180644c42be5096c1b2afa36c625a@changeid
drivers/net/wireless/intel/iwlwifi/mld/power.c
drivers/net/wireless/intel/iwlwifi/mld/regulatory.c

index 8cc276041360ee27c80624f5bf4b378d467488b1..f664b277adf7d5de92564018059ee866b4d0f86b 100644 (file)
@@ -377,23 +377,15 @@ int iwl_mld_set_tx_power(struct iwl_mld *mld,
        u16 u_tx_power = tx_power == IWL_DEFAULT_MAX_TX_POWER ?
                IWL_DEV_MAX_TX_POWER : 8 * tx_power;
        struct iwl_dev_tx_power_cmd cmd = {
-               /* Those fields sit on the same place for v9 and v10 */
                .common.set_mode = cpu_to_le32(IWL_TX_POWER_MODE_SET_LINK),
                .common.pwr_restriction = cpu_to_le16(u_tx_power),
        };
-       u8 cmd_ver = iwl_fw_lookup_cmd_ver(mld->fw, cmd_id,
-                                          IWL_FW_CMD_VER_UNKNOWN);
-       int len = sizeof(cmd.common);
+       int len = sizeof(cmd.common) + sizeof(cmd.v10);
 
        if (WARN_ON(!mld_link))
                return -ENODEV;
 
        cmd.common.link_id = cpu_to_le32(mld_link->fw_id);
 
-       if (cmd_ver == 10)
-               len += sizeof(cmd.v10);
-       else if (cmd_ver == 9)
-               len += sizeof(cmd.v9);
-
        return iwl_mld_send_cmd_pdu(mld, cmd_id, &cmd, len);
 }
index 887f1fb2f92630580acf1c8acfdeb1cfa079c324..b82ddd629e249fe8056d916439b48a9bb8166d9b 100644 (file)
@@ -120,37 +120,20 @@ int iwl_mld_config_sar_profile(struct iwl_mld *mld, int prof_a, int prof_b)
        u32 cmd_id = REDUCE_TX_POWER_CMD;
        struct iwl_dev_tx_power_cmd cmd = {
                .common.set_mode = cpu_to_le32(IWL_TX_POWER_MODE_SET_CHAINS),
+               .v10.flags = cpu_to_le32(mld->fwrt.reduced_power_flags),
        };
-       __le16 *per_chain;
        int ret;
-       u16 len = sizeof(cmd.common);
-       u32 n_subbands;
-       u8 cmd_ver = iwl_fw_lookup_cmd_ver(mld->fw, cmd_id,
-                                          IWL_FW_CMD_VER_UNKNOWN);
-
-       if (cmd_ver == 10) {
-               len += sizeof(cmd.v10);
-               n_subbands = IWL_NUM_SUB_BANDS_V2;
-               per_chain = &cmd.v10.per_chain[0][0][0];
-               cmd.v10.flags =
-                       cpu_to_le32(mld->fwrt.reduced_power_flags);
-       } else if (cmd_ver == 9) {
-               len += sizeof(cmd.v9);
-               n_subbands = IWL_NUM_SUB_BANDS_V1;
-               per_chain = &cmd.v9.per_chain[0][0];
-       } else {
-               return -EOPNOTSUPP;
-       }
 
        /* TODO: CDB - support IWL_NUM_CHAIN_TABLES_V2 */
-       ret = iwl_sar_fill_profile(&mld->fwrt, per_chain,
-                                  IWL_NUM_CHAIN_TABLES,
-                                  n_subbands, prof_a, prof_b);
+       ret = iwl_sar_fill_profile(&mld->fwrt, &cmd.v10.per_chain[0][0][0],
+                                  IWL_NUM_CHAIN_TABLES, IWL_NUM_SUB_BANDS_V2,
+                                  prof_a, prof_b);
        /* return on error or if the profile is disabled (positive number) */
        if (ret)
                return ret;
 
-       return iwl_mld_send_cmd_pdu(mld, cmd_id, &cmd, len);
+       return iwl_mld_send_cmd_pdu(mld, cmd_id, &cmd,
+                                   sizeof(cmd.common) + sizeof(cmd.v10));
 }
 
 int iwl_mld_init_sar(struct iwl_mld *mld)