]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
PCI: exynos: Switch to devm_clk_bulk_get_all_enabled()
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Tue, 17 Dec 2024 21:41:52 +0000 (23:41 +0200)
committerStephen Boyd <sboyd@kernel.org>
Mon, 23 Dec 2024 20:53:52 +0000 (12:53 -0800)
The helper devm_clk_bulk_get_all_enable() missed to return the number of
clocks stored in the clk_bulk_data table referenced by the clks
argument and, therefore, will be dropped.

Use the newly introduced devm_clk_bulk_get_all_enabled() variant
instead, which is consistent with devm_clk_bulk_get_all() in terms of
the returned value:

 > 0 if one or more clocks have been stored
 = 0 if there are no clocks
 < 0 if an error occurred

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Link: https://lore.kernel.org/r/20241217-clk_bulk_ena_fix-v5-2-aafbbb245155@collabora.com
Acked-by: Krzysztof WilczyƄski <kwilczynski@kernel.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/pci/controller/dwc/pci-exynos.c

index 6a830166d37fff5bbbc35aaa7cc1b67b03e6ec3b..ace736b025b1b7d4cdcbd51d2e9d99af29f21149 100644 (file)
@@ -300,7 +300,7 @@ static int exynos_pcie_probe(struct platform_device *pdev)
        if (IS_ERR(ep->elbi_base))
                return PTR_ERR(ep->elbi_base);
 
-       ret = devm_clk_bulk_get_all_enable(dev, &ep->clks);
+       ret = devm_clk_bulk_get_all_enabled(dev, &ep->clks);
        if (ret < 0)
                return ret;