NFSD: nfsd_unlink() clobbers non-zero status returned from fh_fill_pre_attrs()

commit d7d8e3169b56e7696559a2427c922c0d55debcec upstream.

If fh_fill_pre_attrs() returns a non-zero status, the error flow
takes it through out_unlock, which then overwrites the returned
status code with

	err = nfserrno(host_err);

Fixes: a332018a91c4 ("nfsd: handle failure to collect pre/post-op attrs more sanely")
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index d6d4f2a0e898267816538bdb9416fbdf1dc8c5ed..82530d5056269c811856b51ff33f91b08764aa51 100644 (file)
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -2015,11 +2015,9 @@ out_nfserr:
                 * error status.
                 */
                err = nfserr_file_open;
-       } else {
-               err = nfserrno(host_err);
        }
 out:
-       return err;
+       return err != nfs_ok ? err : nfserrno(host_err);
 out_unlock:
        inode_unlock(dirp);
        goto out_drop_write;