]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
tools/cgdelete: use exit code 129 on invalid usage
authorKamalesh Babulal <kamalesh.babulal@oracle.com>
Thu, 29 Sep 2022 10:20:13 +0000 (15:50 +0530)
committerTom Hromatka <tom.hromatka@oracle.com>
Fri, 30 Sep 2022 14:34:55 +0000 (08:34 -0600)
The exit code 1 refers to general error and using -1 wraps to
255, both codes do not signify bad arguments. Let's use exit code 129
(EXIT_BADARGS) for hinting to the users about invalid usage.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
src/tools/cgdelete.c

index 28ddca35cfbc226abcb03febe5602d6253ab0c78..8bedc5de2ffad63e2930215311558a69cd7351d4 100644 (file)
@@ -125,7 +125,7 @@ int main(int argc, char *argv[])
 
        if (argc < 2) {
                usage(1, argv[0]);
-               exit (1);
+               exit(EXIT_BADARGS);
        }
 
        /* initialize libcg */
@@ -160,7 +160,7 @@ int main(int argc, char *argv[])
                        ret = parse_cgroup_spec(cgroup_list, optarg, argc);
                        if (ret != 0) {
                                err("%s: error parsing cgroup '%s'", argv[0], optarg);
-                               ret = -1;
+                               ret = EXIT_BADARGS;
                                goto err;
                        }
                        break;
@@ -170,7 +170,7 @@ int main(int argc, char *argv[])
                        goto err;
                default:
                        usage(1, argv[0]);
-                       ret = -1;
+                       ret = EXIT_BADARGS;
                        goto err;
                }
        }
@@ -180,7 +180,7 @@ int main(int argc, char *argv[])
                ret = parse_cgroup_spec(cgroup_list, argv[i], argc);
                if (ret != 0) {
                        err("%s: error parsing cgroup '%s'\n", argv[0], argv[i]);
-                       ret = -1;
+                       ret = EXIT_BADARGS;
                        goto err;
                }
        }