drm/i915/psr: Write the PR config DPCDs in burst mode

Replace the consecutive single-byte writes to PANEL_REPLAY_CONFIG and
CONFIG2 with one drm_dp_dpcd_write() burst starting at PANEL_REPLAY_CONFIG,
reducing AUX transactions.

v2: Drop extra conditions, and optimize variables. (Ville)
v3: Drop the error check after write. (Ville)

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260527041050.601735-5-ankit.k.nautiyal@intel.com

diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 138907537d03c8f71f8ce65a65845389b3959977..ebacd3e74ad88019e2fcb7d34d5c2d9400130590 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -793,27 +793,27 @@ static bool psr2_su_region_et_valid(struct intel_connector *connector, bool pane
 static void _panel_replay_enable_sink(struct intel_dp *intel_dp,
                                      const struct intel_crtc_state *crtc_state)
 {
-       u8 val = DP_PANEL_REPLAY_ENABLE |
-               DP_PANEL_REPLAY_VSC_SDP_CRC_EN |
-               DP_PANEL_REPLAY_UNRECOVERABLE_ERROR_EN |
-               DP_PANEL_REPLAY_RFB_STORAGE_ERROR_EN |
-               DP_PANEL_REPLAY_ACTIVE_FRAME_CRC_ERROR_EN;
-       u8 panel_replay_config2 = DP_PANEL_REPLAY_CRC_VERIFICATION;
+       u8 panel_replay_config[2];
+
+       panel_replay_config[0] = DP_PANEL_REPLAY_ENABLE |
+                                DP_PANEL_REPLAY_VSC_SDP_CRC_EN |
+                                DP_PANEL_REPLAY_UNRECOVERABLE_ERROR_EN |
+                                DP_PANEL_REPLAY_RFB_STORAGE_ERROR_EN |
+                                DP_PANEL_REPLAY_ACTIVE_FRAME_CRC_ERROR_EN;
+       panel_replay_config[1] = DP_PANEL_REPLAY_CRC_VERIFICATION;
 
        if (crtc_state->has_sel_update)
-               val |= DP_PANEL_REPLAY_SU_ENABLE;
+               panel_replay_config[0] |= DP_PANEL_REPLAY_SU_ENABLE;
 
        if (crtc_state->enable_psr2_su_region_et)
-               val |= DP_PANEL_REPLAY_ENABLE_SU_REGION_ET;
+               panel_replay_config[0] |= DP_PANEL_REPLAY_ENABLE_SU_REGION_ET;
 
        if (crtc_state->req_psr2_sdp_prior_scanline)
-               panel_replay_config2 |=
+               panel_replay_config[1] |=
                        DP_PANEL_REPLAY_SU_REGION_SCANLINE_CAPTURE;
 
-       drm_dp_dpcd_writeb(&intel_dp->aux, PANEL_REPLAY_CONFIG, val);
-
-       drm_dp_dpcd_writeb(&intel_dp->aux, PANEL_REPLAY_CONFIG2,
-                          panel_replay_config2);
+       drm_dp_dpcd_write(&intel_dp->aux, PANEL_REPLAY_CONFIG,
+                         panel_replay_config, sizeof(panel_replay_config));
 }
 
 static void _psr_enable_sink(struct intel_dp *intel_dp,