lxccontainer: avoid NULL pointer dereference

In case the lxc command socket is hashed and the socket was created for a
different path than the one we're currently querying
lxc_cmd_get_{lxcpath,name}() can return NULL. The command socket path is hashed
when len(lxcpath) > sizeof(sun_path) - 2.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c
index 8d31f396190dda042c8d3fce08d220cff5439cc7..e7c9113b4e5ed065af0f0f8bd71c9d942cda5b12 100644 (file)
--- a/src/lxc/lxccontainer.c
+++ b/src/lxc/lxccontainer.c
@@ -3584,7 +3584,10 @@ int list_active_containers(const char *lxcpath, char ***nret,
                *p2 = '\0';
 
                if (is_hashed) {
-                       if (strncmp(lxcpath, lxc_cmd_get_lxcpath(p), lxcpath_len) != 0)
+                       char *recvpath = lxc_cmd_get_lxcpath(p);
+                       if (!recvpath)
+                               continue;
+                       if (strncmp(lxcpath, recvpath, lxcpath_len) != 0)
                                continue;
                        p = lxc_cmd_get_name(p);
                }