]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: make virDomainDefFormatBlkiotune() void
authorMatt Coleman <mcoleman@datto.com>
Fri, 6 Nov 2020 03:32:52 +0000 (22:32 -0500)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 11 Nov 2020 11:53:11 +0000 (12:53 +0100)
This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/domain_conf.c

index 4cea54761fcbe86c9c6c6dbe8039beff5148eb14..fcff4a56d917c765f9e6ebed347014eabb8e925f 100644 (file)
@@ -29498,7 +29498,7 @@ virDomainVsockDefFormat(virBufferPtr buf,
 }
 
 
-static int
+static void
 virDomainDefFormatBlkiotune(virBufferPtr buf,
                             virDomainDefPtr def)
 {
@@ -29539,8 +29539,6 @@ virDomainDefFormatBlkiotune(virBufferPtr buf,
     }
 
     virXMLFormatElement(buf, "blkiotune", NULL, &childrenBuf);
-
-    return 0;
 }
 
 
@@ -29986,8 +29984,7 @@ virDomainDefFormatInternalSetRootName(virDomainDefPtr def,
     virBufferAsprintf(buf, "<currentMemory unit='KiB'>%llu</currentMemory>\n",
                       def->mem.cur_balloon);
 
-    if (virDomainDefFormatBlkiotune(buf, def) < 0)
-        return -1;
+    virDomainDefFormatBlkiotune(buf, def);
 
     virDomainMemtuneFormat(buf, &def->mem);
     virDomainMemorybackingFormat(buf, &def->mem);