]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_driver: fix setting vcpu_quota if not all vCPUs are online
authorPavel Hrdina <phrdina@redhat.com>
Mon, 15 Mar 2021 13:10:45 +0000 (14:10 +0100)
committerPavel Hrdina <phrdina@redhat.com>
Mon, 15 Mar 2021 14:00:53 +0000 (15:00 +0100)
When switching to g_autoptr this was incorrectly changed from
'continue;' into 'return -1;' resulting into an error when user tries
to set vcpu_quota of running VM:

    error: An error occurred, but the cause is unknown

Fixes: e4a8bbfaf2b4cdd741bb441873bb730f9134b714
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/qemu/qemu_driver.c

index b7c89a826a4e1ae63bf3904cef8ef74793095c6a..16c5ccae45ac7cfdeb50693bfef34ccc87e4202c 100644 (file)
@@ -9204,7 +9204,7 @@ qemuSetVcpusBWLive(virDomainObjPtr vm, virCgroupPtr cgroup,
         virDomainVcpuDefPtr vcpu = virDomainDefGetVcpu(vm->def, i);
 
         if (!vcpu->online)
-            return -1;
+            continue;
 
         if (virCgroupNewThread(cgroup, VIR_CGROUP_THREAD_VCPU, i,
                                false, &cgroup_vcpu) < 0)