Making all system calls use paramter arguments

diff --git a/backdoor.cgi b/backdoor.cgi
index b4848a1bb9651ae46c8ec402e3dc18a29d9a0fd5..f46cb67592092aee34d7fa5cef60adc5e4a727de 100755 (executable)
--- a/backdoor.cgi
+++ b/backdoor.cgi
@@ -175,4 +175,4 @@ foreach my $cc (split(/,/, $::FORM{'cc'})) {
 }
 
 print "Created bugzilla bug $zillaid\n";
-system("./processmail $zillaid");
+system("./processmail", $zillaid);

diff --git a/checksetup.pl b/checksetup.pl
index 0b76a8fdccffd60463a1cdf90430ef935ba44040..f283962aeb63071abe16f07719e2247c47012ee2 100755 (executable)
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -1668,7 +1668,7 @@ if ( CountIndexes('keywords') != 3 ) {
 # Final checks...
 if ($regenerateshadow) {
     print "Now regenerating the shadow database for all bugs.\n";
-    system("./processmail regenerate");
+    system("./processmail", "regenerate");
 }
 
 unlink "data/versioncache";

diff --git a/createattachment.cgi b/createattachment.cgi
index fa370d71034251504bac20181d23c7fcefe55ad8..038b63094fa02f64c0b6ef2e61ac6e5ec7e87dd4 100755 (executable)
--- a/createattachment.cgi
+++ b/createattachment.cgi
@@ -106,7 +106,7 @@ What kind of file is this?
                   "Created an attachment (id=$attachid)\n$desc\n");
 
     print "<TABLE BORDER=1><TD><H2>Attachment to bug $id created</H2>\n";
-    system("./processmail $id $::COOKIE{'Bugzilla_login'}");
+    system("./processmail", $id, $::COOKIE{'Bugzilla_login'});
     print "<TD><A HREF=\"show_bug.cgi?id=$id\">Go Back to BUG# $id</A></TABLE>\n";
 }
 

diff --git a/doeditparams.cgi b/doeditparams.cgi
index d37bb042a4fa19c34532a0e3c92caf8d15fb82ee..cc7b661071f88bacd6bc7d0b4a22f1acdc196b0f 100755 (executable)
--- a/doeditparams.cgi
+++ b/doeditparams.cgi
@@ -73,7 +73,7 @@ WriteParams();
 
 unlink "data/versioncache";
 print "<PRE>";
-system("./syncshadowdb -v");
+system("./syncshadowdb", "-v");
 print "</PRE>";
 
 print "OK, done.<p>\n";

diff --git a/post_bug.cgi b/post_bug.cgi
index 5695e5f0c220f9da705b961864a89980a16c9099..3f933e2d2fdb902ff4a451cfe076acde3ca4c9fc 100755 (executable)
--- a/post_bug.cgi
+++ b/post_bug.cgi
@@ -229,7 +229,7 @@ foreach my $person (keys %ccids) {
 }
 
 print "<TABLE BORDER=1><TD><H2>Bug $id posted</H2>\n";
-system("./processmail $id $::COOKIE{'Bugzilla_login'}");
+system("./processmail", $id, $::COOKIE{'Bugzilla_login'});
 print "<TD><A HREF=\"show_bug.cgi?id=$id\">Back To BUG# $id</A></TABLE>\n";
 
 print "<BR><A HREF=\"createattachment.cgi?id=$id\">Attach a file to this bug</a>\n";

diff --git a/process_bug.cgi b/process_bug.cgi
index 8d88ef85ce2cc9fea5939c600c190e6df70ed5a7..11e6040874faf828ecbe895b5fc1a0cd4ce45b80 100755 (executable)
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -512,7 +512,7 @@ SWITCH: for ($::FORM{'knob'}) {
         $::FORM{'comment'} .= "\n\n*** This bug has been marked as a duplicate of $num ***";
 
         print "<TABLE BORDER=1><TD><H2>Notation added to bug $num</H2>\n";
-        system("./processmail $num $::FORM{'who'}");
+        system("./processmail", $num, $::FORM{'who'});
         print "<TD><A HREF=\"show_bug.cgi?id=$num\">Go To BUG# $num</A></TABLE>\n";
 
         last SWITCH;
@@ -901,7 +901,7 @@ The changes made were:
 
     foreach my $k (keys(%dependencychanged)) {
         print "<TABLE BORDER=1><TD><H2>Checking for dependency changes on bug $k</H2>\n";
-        system("./processmail $k $::FORM{'who'}");
+        system("./processmail", $k, $::FORM{'who'});
         print "<TD><A HREF=\"show_bug.cgi?id=$k\">Go To BUG# $k</A></TABLE>\n";
     }