]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: intel8x0: Fix incorrect codec index usage in mixer for ICH4
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Sat, 21 Jun 2025 18:52:24 +0000 (11:52 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:25:54 +0000 (16:25 +0200)
[ Upstream commit 87aafc8580acf87fcaf1a7e30ed858d8c8d37d81 ]

code mistakenly used a hardcoded index (codec[1]) instead of
iterating, over the codec array using the loop variable i.
Use codec[i] instead of codec[1] to match the loop iteration.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link: https://patch.msgid.link/20250621185233.4081094-1-alok.a.tiwari@oracle.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/intel8x0.c

index ae285c0a629c82a518af20812d681526b4e61a73..f3df6fe2b7f18749c078a80a3569d7e92c4cdea9 100644 (file)
@@ -2252,7 +2252,7 @@ static int snd_intel8x0_mixer(struct intel8x0 *chip, int ac97_clock,
                        tmp |= chip->ac97_sdin[0] << ICH_DI1L_SHIFT;
                        for (i = 1; i < 4; i++) {
                                if (pcm->r[0].codec[i]) {
-                                       tmp |= chip->ac97_sdin[pcm->r[0].codec[1]->num] << ICH_DI2L_SHIFT;
+                                       tmp |= chip->ac97_sdin[pcm->r[0].codec[i]->num] << ICH_DI2L_SHIFT;
                                        break;
                                }
                        }