]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
6.17-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Dec 2025 06:31:01 +0000 (07:31 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Dec 2025 06:31:01 +0000 (07:31 +0100)
added patches:
asoc-codecs-nau8325-silence-uninitialized-variables-warnings.patch

queue-6.17/asoc-codecs-nau8325-silence-uninitialized-variables-warnings.patch [new file with mode: 0644]
queue-6.17/series

diff --git a/queue-6.17/asoc-codecs-nau8325-silence-uninitialized-variables-warnings.patch b/queue-6.17/asoc-codecs-nau8325-silence-uninitialized-variables-warnings.patch
new file mode 100644 (file)
index 0000000..0056a2e
--- /dev/null
@@ -0,0 +1,46 @@
+From 2c7e5e17c05f1d5e10e63e1baff2b362cd08dcd6 Mon Sep 17 00:00:00 2001
+From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
+Date: Wed, 3 Dec 2025 15:06:12 +0100
+Subject: ASoC: codecs: nau8325: Silence uninitialized variables warnings
+
+From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
+
+commit 2c7e5e17c05f1d5e10e63e1baff2b362cd08dcd6 upstream.
+
+clang W=1 builds warn:
+
+  nau8325.c:430:13: error: variable 'n2_max' is uninitialized when used here [-Werror,-Wuninitialized]
+
+which are false positive, because the variables will be always
+initialized when used (guarded by mclk_max!=0 check).  However
+initializing them upfront makes the code more obvious and easier, plus
+it silences the warning.
+
+Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
+Link: https://patch.msgid.link/20251203140611.87191-2-krzysztof.kozlowski@oss.qualcomm.com
+Signed-off-by: Mark Brown <broonie@kernel.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ sound/soc/codecs/nau8325.c |    4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+--- a/sound/soc/codecs/nau8325.c
++++ b/sound/soc/codecs/nau8325.c
+@@ -386,7 +386,8 @@ static int nau8325_clksrc_choose(struct
+                                const struct nau8325_srate_attr **srate_table,
+                                int *n1_sel, int *mult_sel, int *n2_sel)
+ {
+-      int i, j, mclk, mclk_max, ratio, ratio_sel, n2_max;
++      int i, j, mclk, ratio;
++      int mclk_max = 0, ratio_sel = 0, n2_max = 0;
+       if (!nau8325->mclk || !nau8325->fs)
+               goto proc_err;
+@@ -408,7 +409,6 @@ static int nau8325_clksrc_choose(struct
+       }
+       /* Get MCLK_SRC through 1/N, Multiplier, and then 1/N2. */
+-      mclk_max = 0;
+       for (i = 0; i < ARRAY_SIZE(mclk_n1_div); i++) {
+               for (j = 0; j < ARRAY_SIZE(mclk_n3_mult); j++) {
+                       mclk = nau8325->mclk << mclk_n3_mult[j].param;
index c801fc9f254f1c90869252a9ce5e42d9412935bc..d2a0eaec8a88ec310d7977e2a35428d9bc1cac68 100644 (file)
@@ -504,3 +504,4 @@ alsa-hda-realtek-add-match-for-asus-xbox-ally-projects.patch
 alsa-hda-tas2781-fix-speaker-id-retrieval-for-multiple-probes.patch
 alsa-hda-cs35l41-fix-null-pointer-dereference-in-cs35l41_hda_read_acpi.patch
 alsa-wavefront-fix-integer-overflow-in-sample-size-validation.patch
+asoc-codecs-nau8325-silence-uninitialized-variables-warnings.patch