s3: libsmbclient: Fix smbc_getxattr() to return 0 on success.

Remove knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14808

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Mulder <dmulder@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov  1 18:31:22 UTC 2022 on sn-devel-184

(cherry picked from commit bdbb38d16c8eaff33484bb747efa639c4d8e7f35)

diff --git a/selftest/knownfail.d/libsmbclient_getxattr b/selftest/knownfail.d/libsmbclient_getxattr
deleted file mode 100644 (file)
index f27656f..0000000
--- a/selftest/knownfail.d/libsmbclient_getxattr
+++ /dev/null
@@ -1 +0,0 @@
-^samba4.libsmbclient.getxattr.*

diff --git a/source3/libsmb/libsmb_xattr.c b/source3/libsmb/libsmb_xattr.c
index d66ea63617c81a2daf2556de87fd0e50f24ee91a..c7091ffaca2b50c019a65227a8b6e05d9918fc64 100644 (file)
--- a/source3/libsmb/libsmb_xattr.c
+++ b/source3/libsmb/libsmb_xattr.c
@@ -2176,7 +2176,11 @@ SMBC_getxattr_ctx(SMBCCTX *context,
                         errno = SMBC_errno(context, srv->cli);
                 }
                TALLOC_FREE(frame);
-                return ret;
+               /*
+                * static function cacl_get returns a value greater than zero
+                * on success. Map this to zero meaning success.
+                */
+                return ret < 0 ? -1 : 0;
         }
 
         /* Unsupported attribute name */