]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
ssl: fix coverity 1451515: out of bounds memory access
authorPauli <ppzgs1@gmail.com>
Wed, 17 Mar 2021 02:00:42 +0000 (12:00 +1000)
committerPauli <ppzgs1@gmail.com>
Thu, 18 Mar 2021 11:21:06 +0000 (21:21 +1000)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14585)

(cherry picked from commit 3de7f014a985637361bdee775f78209300c88aae)

ssl/statem/statem_clnt.c

index d84cc0460f4e2e4f5383eb1b28fd3e410d1ba954..09fba3d8c0c7283a3058c9377c076184e3e0e3bc 100644 (file)
@@ -2905,6 +2905,7 @@ static int tls_construct_cke_psk_preamble(SSL *s, WPACKET *pkt)
     if (psklen > PSK_MAX_PSK_LEN) {
         SSLfatal(s, SSL_AD_HANDSHAKE_FAILURE,
                  SSL_F_TLS_CONSTRUCT_CKE_PSK_PREAMBLE, ERR_R_INTERNAL_ERROR);
+        psklen = PSK_MAX_PSK_LEN;   /* Avoid overrunning the array on cleanse */
         goto err;
     } else if (psklen == 0) {
         SSLfatal(s, SSL_AD_HANDSHAKE_FAILURE,