]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
dhcp/eve: remove erroneous jsonbuilder close
authorJason Ish <jason.ish@oisf.net>
Mon, 29 Jun 2020 17:11:36 +0000 (11:11 -0600)
committerVictor Julien <victor@inliniac.net>
Mon, 29 Jun 2020 18:10:46 +0000 (20:10 +0200)
The JsonBuilder was being closed to early.

src/output-json-dhcp.c

index ecdd9d237c1d7a996176c4b61d6d790ae3d6632f..73a3d2303fdcda7b5cae485cb0c4ead75e761a51 100644 (file)
@@ -77,9 +77,6 @@ static int JsonDHCPLogger(ThreadVars *tv, void *thread_data,
     EveAddCommonOptions(&thread->dhcplog_ctx->cfg, p, f, js);
 
     rs_dhcp_logger_log(ctx->rs_logger, tx, js);
-    if (!jb_close(js)) {
-        goto fail;
-    }
 
     EveAddCommonOptions(&thread->dhcplog_ctx->cfg, p, f, js);
     MemBufferReset(thread->buffer);
@@ -87,10 +84,6 @@ static int JsonDHCPLogger(ThreadVars *tv, void *thread_data,
     jb_free(js);
 
     return TM_ECODE_OK;
-
-fail:
-    jb_free(js);
-    return TM_ECODE_FAILED;
 }
 
 static void OutputDHCPLogDeInitCtxSub(OutputCtx *output_ctx)