]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
r8152: Fix double consecutive clearing of PLA_MCU_SPDWN_EN bit
authorBirger Koblitz <mail@birger-koblitz.de>
Tue, 28 Apr 2026 03:43:38 +0000 (05:43 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Apr 2026 00:55:07 +0000 (17:55 -0700)
Due to a Copy & Paste Error, the PLA_MCU_SPDWN_EN bit was cleared
twice consecutively using ocp_word_clr_bits. Fix that.

Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Link: https://patch.msgid.link/20260428-patch_double-v1-1-27c830a9eb2e@birger-koblitz.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/r8152.c

index 7337bf1b7d6ad03572edbc492706c07a8f58760f..7dba5f3fd052d4db475e61f5c622d89ada1948c1 100644 (file)
@@ -6839,9 +6839,6 @@ static void rtl8156_up(struct r8152 *tp)
        ocp_word_w0w1(tp, MCU_TYPE_PLA, PLA_RXFIFO_FULL, RXFIFO_FULL_MASK,
                      0x08);
 
-       ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3,
-                         PLA_MCU_SPDWN_EN);
-
        ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN);
 
        if (tp->version != RTL_VER_16)