]> git.ipfire.org Git - thirdparty/dnspython.git/commitdiff
lint
authorBob Halley <halley@dnspython.org>
Sat, 26 Jul 2025 15:51:20 +0000 (08:51 -0700)
committerBob Halley <halley@dnspython.org>
Sat, 26 Jul 2025 15:51:20 +0000 (08:51 -0700)
dns/message.py
dns/resolver.py
dns/zone.py
dns/zonefile.py
tests/test_svcb.py
tests/test_zone.py

index b6cc2103dd038e174b6ce11a8efc04bc07e2d602..cd577af9e7133aab4c8893dfe64db132116502ed 100644 (file)
@@ -1738,7 +1738,7 @@ def from_file(
     """
 
     if isinstance(f, str):
-        cm: contextlib.AbstractContextManager = open(f, "rt", encoding="utf-8")
+        cm: contextlib.AbstractContextManager = open(f, encoding="utf-8")
     else:
         cm = contextlib.nullcontext(f)
     with cm as f:
index f7550cae60409976eeed36f4570e2936e84ca196..29133635cc54012e0a8db138e1167e767c6ccf03 100644 (file)
@@ -998,7 +998,7 @@ class BaseResolver:
         nameservers = []
         if isinstance(f, str):
             try:
-                cm: contextlib.AbstractContextManager = open(f, "rt", encoding="utf-8")
+                cm: contextlib.AbstractContextManager = open(f, encoding="utf-8")
             except OSError:
                 # /etc/resolv.conf doesn't exist, can't be read, etc.
                 raise NoResolverConfiguration(f"cannot open {f}")
index 1803979165fdd9aa1c6d8c570fc7358f3b97ee6e..b1a52f6325ab191b3f5ddd3922a2a1079b79ade0 100644 (file)
@@ -1378,7 +1378,7 @@ def from_file(
     if isinstance(f, str):
         if filename is None:
             filename = f
-        cm: contextlib.AbstractContextManager = open(f, "rt", encoding="utf-8")
+        cm: contextlib.AbstractContextManager = open(f, encoding="utf-8")
     else:
         cm = contextlib.nullcontext(f)
     with cm as f:
index fd0f4642488cd92b430ba74b66db3fbc1815620a..f7bcb12cdbb000e18598154d6bce8b249e26b0b4 100644 (file)
@@ -537,7 +537,7 @@ class Reader:
                                 self.default_ttl_known,
                             )
                         )
-                        self.current_file = open(filename, "rt", encoding="utf-8")
+                        self.current_file = open(filename, encoding="utf-8")
                         self.tok = dns.tokenizer.Tokenizer(self.current_file, filename)
                         self.current_origin = new_origin
                     elif c == "$GENERATE":
index e92ec453ead4beddf38958cd00e4eb1281040e97..c62a393e23dccfe8b61d62c406e3fa8fdc99a54c 100644 (file)
@@ -303,11 +303,11 @@ class SVCBTestCase(unittest.TestCase):
     def test_svcb_spec_test_vectors(self):
         text_file = here("svcb_test_vectors.text")
         text_tokenizer = Tokenizer(
-            open(text_file, "rt", encoding="utf-8"), filename=text_file
+            open(text_file, encoding="utf-8"), filename=text_file
         )
         generic_file = here("svcb_test_vectors.generic")
         generic_tokenizer = Tokenizer(
-            open(generic_file, "rt", encoding="utf-8"), filename=generic_file
+            open(generic_file, encoding="utf-8"), filename=generic_file
         )
 
         while True:
index 1d7cde35b99ee33d112dcdcc10a8ccfa8ca2a22f..35b5f42a8c14a1962310773c170fef41b3f21b48 100644 (file)
@@ -320,8 +320,8 @@ def make_xfr(zone):
 
 
 def compare_files(test_name, a_name, b_name):
-    with open(a_name, "rt", encoding="utf-8") as a:
-        with open(b_name, "rt", encoding="utf-8") as b:
+    with open(a_name, encoding="utf-8") as a:
+        with open(b_name, encoding="utf-8") as b:
             differences = list(difflib.unified_diff(a.readlines(), b.readlines()))
             if len(differences) == 0:
                 return True