libcgroup: Dont assign values to variables inside if conditions

Signed-off-by: Dhaval Giani <dhaval.giani@gmail.com>

diff --git a/src/api.c b/src/api.c
index e822749f21fcc23b5fec267cd3930cc222fde280..d1d31185b7abf4685b94e4b20357fdaa3f12a744 100644 (file)
--- a/src/api.c
+++ b/src/api.c
@@ -439,7 +439,8 @@ static int cgroup_parse_rules(bool cache, uid_t muid,
                if (strncmp(user, "@", 1) == 0) {
                        /* New GID rule. */
                        itr = &(user[1]);
-                       if ((grp = getgrnam(itr))) {
+                       grp = getgrnam(itr);
+                       if (grp) {
                                uid = CGRULE_INVALID;
                                gid = grp->gr_gid;
                        } else {
@@ -455,7 +456,8 @@ static int cgroup_parse_rules(bool cache, uid_t muid,
                        gid = CGRULE_WILD;
                } else if (*itr != '%') {
                        /* New UID rule. */
-                       if ((pwd = getpwnam(user))) {
+                       pwd = getpwnam(user);
+                       if (pwd) {
                                uid = pwd->pw_uid;
                                gid = CGRULE_INVALID;
                        } else {