pyldb: add a FIXME for a non-transitive compare

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c
index 86f96e4b305ac997d8264b14f75fd5d5cfdafe55..42badbc2e3721dc93f59fba06234dd5594e39007 100644 (file)
--- a/lib/ldb/pyldb.c
+++ b/lib/ldb/pyldb.c
@@ -4018,7 +4018,18 @@ static PyObject *py_ldb_msg_richcmp(PyLdbMessageObject *py_msg1,
 
        msg1 = pyldb_Message_AsMessage(py_msg1),
        msg2 = pyldb_Message_AsMessage(py_msg2);
-
+       /*
+        * FIXME: this can be a non-transitive compare, unsuitable for
+        * sorting.
+        *
+        * supposing msg1, msg2, and msg3 have 1, 2, and 3 elements
+        * each. msg2 has a NULL DN, while msg1 has a DN that compares
+        * higher than msg3. Then:
+        *
+        * msg1 < msg2, due to num_elements.
+        * msg2 < msg3, due to num_elements.
+        * msg1 > msg3, due to DNs.
+        */
        if ((msg1->dn != NULL) || (msg2->dn != NULL)) {
                ret = ldb_dn_compare(msg1->dn, msg2->dn);
                if (ret != 0) {