]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: bcm63xx: drop wrong casts in probe()
authorJonas Gorski <jonas.gorski@gmail.com>
Sun, 16 Nov 2025 09:33:34 +0000 (10:33 +0100)
committerMark Brown <broonie@kernel.org>
Sun, 16 Nov 2025 23:59:11 +0000 (23:59 +0000)
Both bs->regs and bs->{rx,tx}_io are tagged __iomem, so we shouldn't
cast them to anything else.

Silences the following sparse warning:

drivers/spi/spi-bcm63xx.c:571:22: warning: cast removes address space '__iomem' of expression
drivers/spi/spi-bcm63xx.c:571:19: warning: incorrect type in assignment (different address spaces)
drivers/spi/spi-bcm63xx.c:571:19:    expected unsigned char [noderef] [usertype] __iomem *tx_io
drivers/spi/spi-bcm63xx.c:571:19:    got unsigned char [usertype] *
drivers/spi/spi-bcm63xx.c:572:22: warning: cast removes address space '__iomem' of expression
drivers/spi/spi-bcm63xx.c:572:19: warning: incorrect type in assignment (different address spaces)
drivers/spi/spi-bcm63xx.c:572:19:    expected unsigned char const [noderef] [usertype] __iomem *rx_io
drivers/spi/spi-bcm63xx.c:572:19:    got unsigned char const [usertype] *

Fixes: b42dfed83d95 ("spi: add Broadcom BCM63xx SPI controller driver")
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20251116093334.17423-1-jonas.gorski@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-bcm63xx.c

index b56210734caafccd1235401dec508c6b6b65fc8e..55db5299d72569dc34d1c9bba78abbf4c433bd80 100644 (file)
@@ -568,8 +568,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
        host->auto_runtime_pm = true;
        bs->msg_type_shift = bs->reg_offsets[SPI_MSG_TYPE_SHIFT];
        bs->msg_ctl_width = bs->reg_offsets[SPI_MSG_CTL_WIDTH];
-       bs->tx_io = (u8 *)(bs->regs + bs->reg_offsets[SPI_MSG_DATA]);
-       bs->rx_io = (const u8 *)(bs->regs + bs->reg_offsets[SPI_RX_DATA]);
+       bs->tx_io = bs->regs + bs->reg_offsets[SPI_MSG_DATA];
+       bs->rx_io = bs->regs + bs->reg_offsets[SPI_RX_DATA];
 
        /* Initialize hardware */
        ret = clk_prepare_enable(bs->clk);