]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
ap_queue_push: update comment to reflect reality
authorGreg Ames <gregames@apache.org>
Thu, 9 Dec 2004 14:11:29 +0000 (14:11 +0000)
committerGreg Ames <gregames@apache.org>
Thu, 9 Dec 2004 14:11:29 +0000 (14:11 +0000)
pointed out by: Ron Park (ronp cnet.com)

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@111385 13f79535-47bb-0310-9956-ffa450edef68

server/mpm/experimental/event/fdqueue.c
server/mpm/worker/fdqueue.c

index 8ffc5114ee6b22d51c535d720b73a991b134a66d..8802daf7a55083a5c8a869c697e037f112e2c800 100644 (file)
@@ -307,9 +307,10 @@ apr_status_t ap_queue_init(fd_queue_t * queue, int queue_capacity,
 }
 
 /**
- * Push a new socket onto the queue. Blocks if the queue is full. Once
- * the push operation has completed, it signals other threads waiting
- * in ap_queue_pop() that they may continue consuming sockets.
+ * Push a new socket onto the queue. 
+ *
+ * precondition: ap_queue_info_wait_for_idler has already been called
+ *               to reserve an idle worker thread
  */
 apr_status_t ap_queue_push(fd_queue_t * queue, apr_socket_t * sd,
                            conn_state_t * cs, apr_pool_t * p)
index b747c63e9b2ad5c8381763584ce3bb824401cd7b..d2d271513a39f5c1d73f9e217ffba5bf312dec68 100644 (file)
@@ -275,9 +275,10 @@ apr_status_t ap_queue_init(fd_queue_t *queue, int queue_capacity, apr_pool_t *a)
 }
 
 /**
- * Push a new socket onto the queue. Blocks if the queue is full. Once
- * the push operation has completed, it signals other threads waiting
- * in ap_queue_pop() that they may continue consuming sockets.
+ * Push a new socket onto the queue. 
+ *
+ * precondition: ap_queue_info_wait_for_idler has already been called
+ *               to reserve an idle worker thread
  */
 apr_status_t ap_queue_push(fd_queue_t *queue, apr_socket_t *sd, apr_pool_t *p)
 {