fs_pin: Allow for the possibility that m_list or s_list go unused.

[ Upstream commit 820f9f147dcce2602eefd9b575bbbd9ea14f0953 ]

This is needed to support lazily umounting locked mounts.  Because the
entire unmounted subtree needs to stay together until there are no
users with references to any part of the subtree.

To support this guarantee that the fs_pin m_list and s_list nodes
are initialized by initializing them in init_fs_pin allowing
for the possibility that pin_insert_group does not touch them.

Further use hlist_del_init in pin_remove so that there is
a hlist_unhashed test before the list we attempt to update
the previous list item.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

diff --git a/fs/fs_pin.c b/fs/fs_pin.c
index 9368236ca100bc311fe721c15eca9e3bfdcb2f0f..569bbd10e374cbf465875854f1ad7f754d6271e3 100644 (file)
--- a/fs/fs_pin.c
+++ b/fs/fs_pin.c
@@ -20,8 +20,8 @@ void pin_put(struct fs_pin *p)
 void pin_remove(struct fs_pin *pin)
 {
        spin_lock(&pin_lock);
-       hlist_del(&pin->m_list);
-       hlist_del(&pin->s_list);
+       hlist_del_init(&pin->m_list);
+       hlist_del_init(&pin->s_list);
        spin_unlock(&pin_lock);
 }