mm/damon/tests/core-kunit: handle alloc failure on damos_test_commit_filter()

commit 3e5c4a1a1737bd79abaaa184233d0f815e62273b upstream.

damon_test_commit_filter() is assuming all dynamic memory allocation in it
will succeed.  Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail.  In
the case, inappropriate memory access can happen.  Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-15-sj@kernel.org
Fixes: f6a4a150f1ec ("mm/damon/tests/core-kunit: add damos_commit_filter test")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org>	[6.18+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 3ad9b851a19e662dfdd7fa2caa88a2d41c313f99..63d10ca934f611deb08eaf229289b7fa7554268d 100644 (file)
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -496,11 +496,16 @@ static void damos_test_new_filter(struct kunit *test)
 
 static void damos_test_commit_filter(struct kunit *test)
 {
-       struct damos_filter *src_filter = damos_new_filter(
-               DAMOS_FILTER_TYPE_ANON, true, true);
-       struct damos_filter *dst_filter = damos_new_filter(
-               DAMOS_FILTER_TYPE_ACTIVE, false, false);
-
+       struct damos_filter *src_filter, *dst_filter;
+
+       src_filter = damos_new_filter(DAMOS_FILTER_TYPE_ANON, true, true);
+       if (!src_filter)
+               kunit_skip(test, "src filter alloc fail");
+       dst_filter = damos_new_filter(DAMOS_FILTER_TYPE_ACTIVE, false, false);
+       if (!dst_filter) {
+               damos_destroy_filter(src_filter);
+               kunit_skip(test, "dst filter alloc fail");
+       }
        damos_commit_filter(dst_filter, src_filter);
        KUNIT_EXPECT_EQ(test, dst_filter->type, src_filter->type);
        KUNIT_EXPECT_EQ(test, dst_filter->matching, src_filter->matching);