]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: rockchip: rga: fix rga offset lookup
authorJohn Keeping <jkeeping@inmusicbrands.com>
Sat, 10 Aug 2024 13:02:54 +0000 (14:02 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Thu, 6 Mar 2025 16:28:26 +0000 (17:28 +0100)
The arguments to rga_lookup_draw_pos() are passed in the wrong order,
rotate mode should be before mirror mode.

Fixes: 558c248f930e6 ("media: rockchip: rga: split src and dst buffer setup")
Cc: stable@vger.kernel.org
Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>
Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/rockchip/rga/rga-hw.c

index bf55beec0fac7a67661681f63cf4aa70ac12743d..43ed742a164929927001ef8e8925a29eb93615b2 100644 (file)
@@ -376,7 +376,7 @@ static void rga_cmd_set_dst_info(struct rga_ctx *ctx,
         * Configure the dest framebuffer base address with pixel offset.
         */
        offsets = rga_get_addr_offset(&ctx->out, offset, dst_x, dst_y, dst_w, dst_h);
-       dst_offset = rga_lookup_draw_pos(&offsets, mir_mode, rot_mode);
+       dst_offset = rga_lookup_draw_pos(&offsets, rot_mode, mir_mode);
 
        dest[(RGA_DST_Y_RGB_BASE_ADDR - RGA_MODE_BASE_REG) >> 2] =
                dst_offset->y_off;