]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
spi: spi-geni-qcom: Correct CS_TOGGLE bit in SPI_TRANS_CFG
authorVijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Tue, 25 Apr 2023 08:42:08 +0000 (14:12 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jul 2023 17:39:26 +0000 (19:39 +0200)
[ Upstream commit 5fd7c99ecf45c8ee8a9b1268f0ffc91cc6271da2 ]

The CS_TOGGLE bit when set is supposed to instruct FW to
toggle CS line between words. The driver with intent of
disabling this behaviour has been unsetting BIT(0). This has
not caused any trouble so far because the original BIT(1)
is untouched and BIT(0) likely wasn't being used.

Correct this to prevent a potential future bug.

Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org
Fixes: 561de45f72bd ("spi: spi-geni-qcom: Add SPI driver support for GENI based QUP")
Reviewed-by: Douglas Anderson <dianders@chromium.org
Link: https://lore.kernel.org/r/1682412128-1913-1-git-send-email-quic_vnivarth@quicinc.com
Signed-off-by: Mark Brown <broonie@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/spi/spi-geni-qcom.c

index baf477383682dc231467019902d2f9f7901ed63d..d147519fe10892e49d27f0f0d3e482e4844304ea 100644 (file)
@@ -35,7 +35,7 @@
 #define CS_DEMUX_OUTPUT_SEL    GENMASK(3, 0)
 
 #define SE_SPI_TRANS_CFG       0x25c
-#define CS_TOGGLE              BIT(0)
+#define CS_TOGGLE              BIT(1)
 
 #define SE_SPI_WORD_LEN                0x268
 #define WORD_LEN_MSK           GENMASK(9, 0)