]> git.ipfire.org Git - thirdparty/vala.git/commitdiff
parser: Improve error message for invalid ArrayCreationExpression 1203f54a72bea601b7635a4895f7f199c70e1e2d
authorRico Tzschichholz <ricotz@ubuntu.com>
Thu, 19 Mar 2020 08:53:27 +0000 (09:53 +0100)
committerRico Tzschichholz <ricotz@ubuntu.com>
Thu, 19 Mar 2020 08:53:27 +0000 (09:53 +0100)
Fixes https://gitlab.gnome.org/GNOME/vala/issues/939

tests/Makefile.am
tests/parser/array-creation-invalid.test [new file with mode: 0644]
vala/valaparser.vala

index 7f7b6f6d331e9be9cd1481717ce396922f15ecaa..036aff1f5bf6fe4a0ec180d62423063bfdb30381 100644 (file)
@@ -620,6 +620,7 @@ TESTS = \
        scanner/string-escape-x-digit-length.test \
        scanner/string-escape-x-empty.test \
        scanner/string-escape-x.vala \
+       parser/array-creation-invalid.test \
        parser/assignment.vala \
        parser/attribute-duplicate.test \
        parser/attribute-wrong-number.test \
diff --git a/tests/parser/array-creation-invalid.test b/tests/parser/array-creation-invalid.test
new file mode 100644 (file)
index 0000000..22d439d
--- /dev/null
@@ -0,0 +1,5 @@
+Invalid Code
+
+void main () {
+       var foo = new int[];
+}
index 62ad72898caff0e4500ce68b1e755892af8425e3..f1b49352df0e697f8bbd2d0996d2d8b7a2e8f450 100644 (file)
@@ -1012,6 +1012,9 @@ public class Vala.Parser : CodeVisitor {
                        foreach (Expression size in size_specifier_list) {
                                expr.append_size (size);
                        }
+               } else if (initializer == null) {
+                       Report.warning (src, "possibly missing array size");
+                       throw new ParseError.SYNTAX ("expected array initializer list");
                }
                return expr;
        }