]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mmc: moxart: replace spin_lock_irqsave by spin_lock in hard IRQ
authorTian Tao <tiantao6@hisilicon.com>
Fri, 30 Oct 2020 01:28:39 +0000 (09:28 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 16 Nov 2020 10:59:29 +0000 (11:59 +0100)
The code has been in a irq-disabled context since it is hard IRQ. There
is no necessity to do it again.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Link: https://lore.kernel.org/r/1604021319-31338-1-git-send-email-tiantao6@hisilicon.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/moxart-mmc.c

index f25079ba3bca294c91da40d0d23b70d5b7dd04f3..89bff4e8ec10a5361ce7666cbc1d7886e12ed01b 100644 (file)
@@ -465,9 +465,8 @@ static irqreturn_t moxart_irq(int irq, void *devid)
 {
        struct moxart_host *host = (struct moxart_host *)devid;
        u32 status;
-       unsigned long flags;
 
-       spin_lock_irqsave(&host->lock, flags);
+       spin_lock(&host->lock);
 
        status = readl(host->base + REG_STATUS);
        if (status & CARD_CHANGE) {
@@ -484,7 +483,7 @@ static irqreturn_t moxart_irq(int irq, void *devid)
        if (status & (FIFO_ORUN | FIFO_URUN) && host->mrq)
                moxart_transfer_pio(host);
 
-       spin_unlock_irqrestore(&host->lock, flags);
+       spin_unlock(&host->lock);
 
        return IRQ_HANDLED;
 }