]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
core/service: add a FIXME to use pidfd to monitor foreign processes 32115/head
authorMike Yuan <me@yhndnzj.com>
Fri, 5 Apr 2024 10:41:07 +0000 (18:41 +0800)
committerMike Yuan <me@yhndnzj.com>
Fri, 5 Apr 2024 18:22:19 +0000 (02:22 +0800)
src/core/service.c

index 7f4e1e4443a45f9258cb1fe15ff3a7e1e9571047..61b2b9a9554dbd559466e1392f616a754bca8c5d 100644 (file)
@@ -222,10 +222,10 @@ static int service_set_main_pidref(Service *s, PidRef pidref_consume) {
         r = pidref_is_my_child(&s->main_pid);
         if (r < 0)
                 log_unit_warning_errno(UNIT(s), r, "Can't determine if process "PID_FMT" is our child, assuming it is not: %m", s->main_pid.pid);
-        else if (r == 0)
+        else if (r == 0) // FIXME: Supervise through pidfd here
                 log_unit_warning(UNIT(s), "Supervising process "PID_FMT" which is not our child. We'll most likely not notice when it exits.", s->main_pid.pid);
-
         s->main_pid_alien = r <= 0;
+
         return 0;
 }