]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
nfc: pn533: properly drop the usb interface reference on disconnect
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Feb 2026 11:28:30 +0000 (12:28 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 26 Feb 2026 02:51:37 +0000 (18:51 -0800)
When the device is disconnected from the driver, there is a "dangling"
reference count on the usb interface that was grabbed in the probe
callback.  Fix this up by properly dropping the reference after we are
done with it.

Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Fixes: c46ee38620a2 ("NFC: pn533: add NXP pn533 nfc device driver")
Link: https://patch.msgid.link/2026022329-flashing-ought-7573@gregkh
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/pn533/usb.c

index 018a80674f06ed9e4b03349bcc5c05c1b273280a..0f12f86ebb023461d489edadfbd01366c52c1804 100644 (file)
@@ -628,6 +628,7 @@ static void pn533_usb_disconnect(struct usb_interface *interface)
        usb_free_urb(phy->out_urb);
        usb_free_urb(phy->ack_urb);
        kfree(phy->ack_buffer);
+       usb_put_dev(phy->udev);
 
        nfc_info(&interface->dev, "NXP PN533 NFC device disconnected\n");
 }