]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clk: imx: imx31: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Fri, 9 Jan 2026 16:57:53 +0000 (17:57 +0100)
committerRob Herring (Arm) <robh@kernel.org>
Wed, 4 Feb 2026 02:58:13 +0000 (20:58 -0600)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Reviewed-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Acked-by: Abel Vesa <abelvesa@kernel.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260109-of-for-each-compatible-scoped-v3-9-c22fa2c0749a@oss.qualcomm.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/clk/imx/clk-imx31.c

index 4c8d9ff0b2ad5654403550365c2b0f39bb21faf0..962eccac63ceafc209f859b3f3b1033a94319e67 100644 (file)
@@ -123,18 +123,15 @@ static void __init _mx31_clocks_init(void __iomem *base, unsigned long fref)
 
 static void __init mx31_clocks_init_dt(struct device_node *np)
 {
-       struct device_node *osc_np;
        u32 fref = 26000000; /* default */
        void __iomem *ccm;
 
-       for_each_compatible_node(osc_np, NULL, "fixed-clock") {
+       for_each_compatible_node_scoped(osc_np, NULL, "fixed-clock") {
                if (!of_device_is_compatible(osc_np, "fsl,imx-osc26m"))
                        continue;
 
-               if (!of_property_read_u32(osc_np, "clock-frequency", &fref)) {
-                       of_node_put(osc_np);
+               if (!of_property_read_u32(osc_np, "clock-frequency", &fref))
                        break;
-               }
        }
 
        ccm = of_iomap(np, 0);