]> git.ipfire.org Git - thirdparty/krb5.git/commitdiff
Remove unneeded check in SPNEGO initiator
authorGreg Hudson <ghudson@mit.edu>
Mon, 16 Dec 2013 16:35:42 +0000 (11:35 -0500)
committerGreg Hudson <ghudson@mit.edu>
Mon, 16 Dec 2013 16:35:52 +0000 (11:35 -0500)
In init_ctx_cont, if the response token contains no fields, we set a
return value but don't actually quit out of the function.  We do not
need this check (we will fail later on if a piece of required
information isn't present), so just remove it.  Reported by
simo@redhat.com.

src/lib/gssapi/spnego/spnego_mech.c

index d82934b6cd6d6144319e2b3e963645300c216c6d..818a1b4439f50abebe80e6abb244ad51d59fc701 100644 (file)
@@ -648,13 +648,6 @@ init_ctx_cont(OM_uint32 *minor_status, gss_ctx_id_t *ctx, gss_buffer_t buf,
                               responseToken, mechListMIC);
        if (ret != GSS_S_COMPLETE)
                goto cleanup;
-       if (acc_negState == ACCEPT_DEFECTIVE_TOKEN &&
-           supportedMech == GSS_C_NO_OID &&
-           *responseToken == GSS_C_NO_BUFFER &&
-           *mechListMIC == GSS_C_NO_BUFFER) {
-               /* Reject "empty" token. */
-               ret = GSS_S_DEFECTIVE_TOKEN;
-       }
        if (acc_negState == REJECT) {
                *minor_status = ERR_SPNEGO_NEGOTIATION_FAILED;
                map_errcode(minor_status);