]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: mipi-csis: Add check for clk_enable()
authorJiasheng Jiang <jiashengjiangcool@gmail.com>
Mon, 25 Nov 2024 19:18:18 +0000 (19:18 +0000)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 19 Dec 2024 11:50:18 +0000 (12:50 +0100)
Add check for the return value of clk_enable() to gurantee the success.

Fixes: b5f1220d587d ("[media] v4l: Add v4l2 subdev driver for S5P/EXYNOS4 MIPI-CSI receivers")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/samsung/exynos4-is/mipi-csis.c

index 63f3eecdd7e6990cbcd735bffbdbf9b92bedeb2b..452880b5350cd1915e5e8db72ee1e3e04dd54baf 100644 (file)
@@ -940,13 +940,19 @@ static int s5pcsis_pm_resume(struct device *dev, bool runtime)
                                               state->supplies);
                        goto unlock;
                }
-               clk_enable(state->clock[CSIS_CLK_GATE]);
+               ret = clk_enable(state->clock[CSIS_CLK_GATE]);
+               if (ret) {
+                       phy_power_off(state->phy);
+                       regulator_bulk_disable(CSIS_NUM_SUPPLIES,
+                                              state->supplies);
+                       goto unlock;
+               }
        }
        if (state->flags & ST_STREAMING)
                s5pcsis_start_stream(state);
 
        state->flags &= ~ST_SUSPENDED;
- unlock:
+unlock:
        mutex_unlock(&state->lock);
        return ret ? -EAGAIN : 0;
 }