]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
9p: acl: fix uninitialized iattr access
authorDominique Martinet <dominique.martinet@cea.fr>
Fri, 7 Sep 2018 15:10:57 +0000 (00:10 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Jul 2019 07:56:35 +0000 (09:56 +0200)
[ Upstream commit e02a53d92e197706cad1627bd84705d4aa20a145 ]

iattr is passed to v9fs_vfs_setattr_dotl which does send various
values from iattr over the wire, even if it tells the server to
only look at iattr.ia_valid fields this could leak some stack data.

Link: http://lkml.kernel.org/r/1536339057-21974-2-git-send-email-asmadeus@codewreck.org
Addresses-Coverity-ID: 1195601 ("Uninitalized scalar variable")
Signed-off-by: Dominique Martinet <dominique.martinet@cea.fr>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/9p/acl.c

index c30c6ceac2c43363701ccbb3a7b8c0660fd69850..d02ee4026e32a013b43ded757c1e543901734a8b 100644 (file)
@@ -282,7 +282,7 @@ static int v9fs_xattr_set_acl(const struct xattr_handler *handler,
        switch (handler->flags) {
        case ACL_TYPE_ACCESS:
                if (acl) {
-                       struct iattr iattr;
+                       struct iattr iattr = { 0 };
                        struct posix_acl *old_acl = acl;
 
                        retval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl);