]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
smb/dcerpc: close request tx sooner
authorVictor Julien <victor@inliniac.net>
Tue, 3 Dec 2019 08:27:34 +0000 (09:27 +0100)
committerVictor Julien <victor@inliniac.net>
Mon, 9 Dec 2019 19:12:03 +0000 (20:12 +0100)
rust/src/smb/dcerpc.rs

index 8890d170debd92c3c0450c4d6555540ee9e561ac..e2f902fdf1d9bfc15c81abb653ce5222e00c6329 100644 (file)
@@ -321,6 +321,7 @@ pub fn smb_write_dcerpc_record<'b>(state: &mut SMBState,
                         },
                         _ => {
                             tx.set_event(SMBEvent::MalformedData);
+                            tx.request_done = true;
                         },
                     }
                 },
@@ -353,17 +354,21 @@ pub fn smb_write_dcerpc_record<'b>(state: &mut SMBState,
                                 }
                                 bind_ifaces = Some(ifaces);
                             }
-                            tx.request_done = true;
                         },
                         _ => {
                             tx.set_event(SMBEvent::MalformedData);
                         },
                     }
+                    tx.request_done = true;
                 }
                 21..=255 => {
                     tx.set_event(SMBEvent::MalformedData);
+                    tx.request_done = true;
+                },
+                _ => {
+                    // valid type w/o special processing
+                    tx.request_done = true;
                 },
-                _ => { }, // valid type w/o special processing
             }
         },
         _ => {