]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Disallow memory tests from running on Windows
authorMike Bayer <mike_mp@zzzcomputing.com>
Fri, 25 Oct 2019 02:29:28 +0000 (22:29 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Fri, 25 Oct 2019 02:29:28 +0000 (22:29 -0400)
These tests fail with multiprocess errors involving pickling
of the profile file.  The memory tests are not critical
for windows development nor are the profiling tests overall
as they are against platform independent measurements.

Fixes: #4946
Change-Id: Iaeb3958e59ce7709ba6af3cf9d7baf2a4922bb9b

lib/sqlalchemy/testing/requirements.py
test/aaa_profiling/test_memusage.py
test/requirements.py

index 62e442b6b4932bfe3f09bf8055529d10b985fa65..c45156d6b4e7efd659ab9a9e207907b8210a64a4 100644 (file)
@@ -15,6 +15,7 @@ to provide specific inclusion/exclusions.
 
 """
 
+import platform
 import sys
 
 from . import exclusions
@@ -951,6 +952,16 @@ class SuiteRequirements(Requirements):
             lambda config: config.options.low_connections
         )
 
+    @property
+    def no_windows(self):
+        return exclusions.skip_if(self._running_on_windows())
+
+    def _running_on_windows(self):
+        return exclusions.LambdaPredicate(
+            lambda: platform.system() == "Windows",
+            description="running on Windows",
+        )
+
     @property
     def timing_intensive(self):
         return exclusions.requires_tag("timing_intensive")
index 431e53b1ba5697ce122901be657f8ea896e5ee23..efeeff9e00ece16c97e9b0ddc93780266bdee152 100644 (file)
@@ -188,7 +188,7 @@ class EnsureZeroed(fixtures.ORMTest):
 
 class MemUsageTest(EnsureZeroed):
     __tags__ = ("memory_intensive",)
-    __requires__ = ("cpython",)
+    __requires__ = ("cpython", "no_windows")
 
     def test_type_compile(self):
         from sqlalchemy.dialects.sqlite.base import dialect as SQLiteDialect
index a0d984ef4b1682258476b51563b4624c7a0370ca..739f90b9551953440464ae3edd63759d2f8a05fc 100644 (file)
@@ -312,6 +312,7 @@ class DefaultRequirements(SuiteRequirements):
             [
                 no_support("oracle", "Oracle XE usually can't handle these"),
                 no_support("mssql+pyodbc", "MS ODBC drivers struggle"),
+                self._running_on_windows(),
             ]
         )