re PR tree-optimization/36978 (ICE in gimple_cond_set_lhs for -O2 -funswitch-loops...

2008-07-31  Richard Guenther  <rguenther@suse.de>

	PR tree-optimization/36978
	* tree-ssa-loop-unswitch.c (tree_may_unswitch_on): Do not fold
	the generated condition.

	* gcc.dg/torture/pr36978.c: New testcase.

From-SVN: r138415

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index cb7a67b651391f7ad165bfb50b959baadad6bd5a..c83a2faa81cdeff93bf19ab01ca6d19effd4cf7d 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2008-07-31  Richard Guenther  <rguenther@suse.de>
+
+       PR tree-optimization/36978
+       * tree-ssa-loop-unswitch.c (tree_may_unswitch_on): Do not fold
+       the generated condition.
+
 2008-07-31  Richard Guenther  <rguenther@suse.de>
 
        * passes.c (init_optimization_passes): Always call

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index ccbd9711809ac475a45e3a8ef82d778854929034..f6e855abd083d7676a9f95d678007e6397395eca 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2008-07-31  Richard Guenther  <rguenther@suse.de>
+
+       PR tree-optimization/36978
+       * gcc.dg/torture/pr36978.c: New testcase.
+
 2008-07-31  Arnaud Charlet  <charlet@adacore.com>
 
        * gnat.dg/sync_iface_test.ad[s,b]: New test.

diff --git a/gcc/testsuite/gcc.dg/torture/pr36978.c b/gcc/testsuite/gcc.dg/torture/pr36978.c
new file mode 100644 (file)
index 0000000..cd1af4e
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr36978.c
@@ -0,0 +1,14 @@
+/* { dg-do compile } */
+/* { dg-options "-funswitch-loops" } */
+
+unsigned short status;
+void foo (const _Bool flag)
+{
+  if (status == 2 || status == 7)
+    {
+      while (status != 2 && (status != 7 || !flag))
+       {
+       }
+    }
+}
+

diff --git a/gcc/tree-ssa-loop-unswitch.c b/gcc/tree-ssa-loop-unswitch.c
index 8ece4aca4ab3f8f3b614ce549ca65ad79e62a013..850270f49c03285d88c07ac1f381d4866834bd29 100644 (file)
--- a/gcc/tree-ssa-loop-unswitch.c
+++ b/gcc/tree-ssa-loop-unswitch.c
@@ -123,8 +123,8 @@ tree_may_unswitch_on (basic_block bb, struct loop *loop)
        return NULL_TREE;
     }
 
-  cond = fold_build2 (gimple_cond_code (stmt), boolean_type_node,
-                     gimple_cond_lhs (stmt), gimple_cond_rhs (stmt));
+  cond = build2 (gimple_cond_code (stmt), boolean_type_node,
+                gimple_cond_lhs (stmt), gimple_cond_rhs (stmt));
 
   /* To keep the things simple, we do not directly remove the conditions,
      but just replace tests with 0/1.  Prevent the infinite loop where we