net: phy: mscc: macsec: Use new AES library API

Switch from the old AES library functions (which use struct
crypto_aes_ctx) to the new ones (which use struct aes_enckey).  This
eliminates the unnecessary computation and caching of the decryption
round keys.  The new AES en/decryption functions are also much faster
and use AES instructions when supported by the CPU.

Note that in addition to the change in the key preparation function and
the key struct type itself, the change in the type of the key struct
results in aes_encrypt() (which is temporarily a type-generic macro)
calling the new encryption function rather than the old one.

Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20260112192035.10427-22-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@kernel.org>

diff --git a/drivers/net/phy/mscc/mscc_macsec.c b/drivers/net/phy/mscc/mscc_macsec.c
index 4f39ba63a9a912caee8e1b59c6f21d55f91fabf4..9a38a29cf3977ae868470558ff8bc03417cf963d 100644 (file)
--- a/drivers/net/phy/mscc/mscc_macsec.c
+++ b/drivers/net/phy/mscc/mscc_macsec.c
@@ -504,15 +504,15 @@ static u32 vsc8584_macsec_flow_context_id(struct macsec_flow *flow)
 static int vsc8584_macsec_derive_key(const u8 *key, u16 key_len, u8 hkey[16])
 {
        const u8 input[AES_BLOCK_SIZE] = {0};
-       struct crypto_aes_ctx ctx;
+       struct aes_enckey aes;
        int ret;
 
-       ret = aes_expandkey(&ctx, key, key_len);
+       ret = aes_prepareenckey(&aes, key, key_len);
        if (ret)
                return ret;
 
-       aes_encrypt(&ctx, hkey, input);
-       memzero_explicit(&ctx, sizeof(ctx));
+       aes_encrypt(&aes, hkey, input);
+       memzero_explicit(&aes, sizeof(aes));
        return 0;
 }