power: supply: bd71828: Use dev_err_probe()

The driver uses separate error printing and error returning at probe()
for locations where the error value is hard-coded and can't be
EPROBE_DEFER. This helps to omit the extra return value check which is
done in dev_err_probe().

Using the dev_err_probe() has some other benefits besides handling the
-EPROBE_DEFER though, like standardizing the print for error numbers.
Some believe thes outweigh the benefit of skipping the extra check.

Use dev_err_probe() consistently in the bd71828 power-supply probe.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Link: https://patch.msgid.link/aWi_GG74sZRfajA_@mva-rohm
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

diff --git a/drivers/power/supply/bd71828-power.c b/drivers/power/supply/bd71828-power.c
index 438e220a9cb7c152d31037c762c0bfd82543b42e..0e00acb589937d776ed141d9fc8f5e653b022519 100644 (file)
--- a/drivers/power/supply/bd71828-power.c
+++ b/drivers/power/supply/bd71828-power.c
@@ -1058,10 +1058,8 @@ static int bd71828_power_probe(struct platform_device *pdev)
                pwr->regmap = dev_get_regmap(pdev->dev.parent, NULL);
        else
                pwr->regmap = dev_get_regmap(pdev->dev.parent, "wrap-map");
-       if (!pwr->regmap) {
-               dev_err(&pdev->dev, "No parent regmap\n");
-               return -EINVAL;
-       }
+       if (!pwr->regmap)
+               return dev_err_probe(&pdev->dev, -EINVAL, "No parent regmap\n");
 
        pwr->dev = &pdev->dev;
 
@@ -1083,8 +1081,7 @@ static int bd71828_power_probe(struct platform_device *pdev)
                dev_dbg(pwr->dev, "Found ROHM BD72720\n");
                break;
        default:
-               dev_err(pwr->dev, "Unknown PMIC\n");
-               return -EINVAL;
+               return dev_err_probe(pwr->dev, -EINVAL, "Unknown PMIC\n");
        }
 
        ret = bd7182x_get_rsens(pwr);