s3:libads: Check print_canonical_sockaddr_with_port() for NULL in get_kdc_ip_string()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15016

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>

diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c
index 2087dc1e6f9ac21419152561d01e80d3d352f3d4..20dceeefb22def1a6a3215a4d95a0942c39038c1 100644 (file)
--- a/source3/libads/kerberos.c
+++ b/source3/libads/kerberos.c
@@ -435,13 +435,18 @@ static char *get_kdc_ip_string(char *mem_ctx,
        NTSTATUS status;
        bool ok;
        char *kdc_str = NULL;
+       char *canon_sockaddr = NULL;
 
        SMB_ASSERT(pss != NULL);
 
+       canon_sockaddr = print_canonical_sockaddr_with_port(frame, pss);
+       if (canon_sockaddr == NULL) {
+               goto out;
+       }
+
        kdc_str = talloc_asprintf(frame,
                                  "\t\tkdc = %s\n",
-                                 print_canonical_sockaddr_with_port(mem_ctx,
-                                                                    pss));
+                                 canon_sockaddr);
        if (kdc_str == NULL) {
                goto out;
        }