]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
network: fix socket handle leak
authorDonghwa Jeong <dh48.jeong@samsung.com>
Mon, 28 May 2018 04:42:45 +0000 (13:42 +0900)
committerChristian Brauner <christian.brauner@ubuntu.com>
Mon, 10 Dec 2018 07:41:50 +0000 (08:41 +0100)
Signed-off-by: Donghwa Jeong <dh48.jeong@samsung.com>
src/lxc/network.c [changed mode: 0644->0755]

old mode 100644 (file)
new mode 100755 (executable)
index 863bb96..a262693
@@ -1946,7 +1946,12 @@ int setup_private_host_hw_addr(char *veth1)
        if (sockfd < 0)
                return -errno;
 
-       snprintf((char *)ifr.ifr_name, IFNAMSIZ, "%s", veth1);
+       err = snprintf((char *)ifr.ifr_name, IFNAMSIZ, "%s", veth1);
+       if (err < 0 || (size_t)err >= IFNAMSIZ) {
+               close(sockfd);
+               return -E2BIG;
+       }
+
        err = ioctl(sockfd, SIOCGIFHWADDR, &ifr);
        if (err < 0) {
                close(sockfd);