]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: renesas: vsp1: Initialize format on all pads
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Wed, 18 Mar 2026 23:59:07 +0000 (01:59 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 25 Mar 2026 09:25:49 +0000 (10:25 +0100)
The state initialization function vsp1_entity_init_state() incorrectly
leaves the last entity pad out when initializing formats due to an off
by one error. Fix it.

Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> # HiHope RZ/G2M
Link: https://patch.msgid.link/20260318235907.831556-14-laurent.pinchart+renesas@ideasonboard.com
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/renesas/vsp1/vsp1_entity.c

index 839b75b62cebadd086a2b9d0a48698091cad011b..1dad9589768c2349b806f5cd7a507990a78789f9 100644 (file)
@@ -380,7 +380,7 @@ static int vsp1_entity_init_state(struct v4l2_subdev *subdev,
        unsigned int pad;
 
        /* Initialize all pad formats with default values. */
-       for (pad = 0; pad < subdev->entity.num_pads - 1; ++pad) {
+       for (pad = 0; pad < subdev->entity.num_pads; ++pad) {
                struct v4l2_subdev_format format = {
                        .pad = pad,
                        .which = sd_state ? V4L2_SUBDEV_FORMAT_TRY