gtkmodule: Error out on malformed signal definition

Connecting to a signal in a gtk composite template needs both the
signal's name and a handler function to connect to.

diff --git a/codegen/valagtkmodule.vala b/codegen/valagtkmodule.vala
index b6c9c300e5c9c74933d89f6bebbe2a9ab01133b9..deb0704552f25e5e6f713a2e94e7de59db282d8b 100644 (file)
--- a/codegen/valagtkmodule.vala
+++ b/codegen/valagtkmodule.vala
@@ -126,7 +126,13 @@ public class Vala.GtkModule : GSignalModule {
                        } else if (current_class != null && current_token == MarkupTokenType.START_ELEMENT && reader.name == "signal") {
                                var signal_name = reader.get_attribute ("name");
                                var handler_name = reader.get_attribute ("handler");
+
                                if (current_class != null) {
+                                       if (signal_name == null || handler_name == null) {
+                                               Report.error (node.source_reference, "Invalid signal in ui file `%s'".printf (ui_file));
+                                               current_token = reader.read_token (null, null);
+                                               continue;
+                                       }
                                        var sep_idx = signal_name.index_of ("::");
                                        if (sep_idx >= 0) {
                                                // detailed signal, we don't care about the detail