]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
storage: don't leak memory for unittests
authorVictor Julien <victor@inliniac.net>
Fri, 26 Oct 2018 14:03:05 +0000 (16:03 +0200)
committerVictor Julien <victor@inliniac.net>
Tue, 30 Oct 2018 09:21:34 +0000 (10:21 +0100)
src/runmode-unittests.c
src/util-storage.c

index 61fd5e6fda70e56c84a803e8e7a260d8360a2967..222ed5f618b429bbfddb4eea94dabdbba29bec8f 100644 (file)
@@ -261,13 +261,13 @@ void RunUnittests(int list_unittests, const char *regex_arg)
     MpmTableSetup();
     SpmTableSetup();
 
+    StorageInit();
     AppLayerSetup();
 
     /* hardcoded initialization code */
     SigTableSetup(); /* load the rule keywords */
     TmqhSetup();
 
-    StorageInit();
     CIDRInit();
 
 #ifdef DBG_MEM_ALLOC
index 1d6ee129a64090dbcb5790f0ff4cc87aba97d01a..894abfdda75b1cf40960d789d5b26d3546632771 100644 (file)
@@ -175,8 +175,11 @@ int StorageFinalize(void)
             storage_map[entry->map.type][entry->id].Free = entry->map.Free;
         }
 
-        entry = entry->next;
+        StorageList *next = entry->next;
+        SCFree(entry);
+        entry = next;
     };
+    storage_list = NULL;
 
 #ifdef DEBUG
     for (i = 0; i < STORAGE_MAX; i++) {