Bug 343361: die_with_dignity is useless inside of Bugzilla::CGI

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, r=colin, a=myk

diff --git a/Bugzilla.pm b/Bugzilla.pm
index 0d6e6af7da87034c5af8f902746155aa667ff83c..e22ab97bf8b4f42812e973f8724ac91789c5e25b 100644 (file)
--- a/Bugzilla.pm
+++ b/Bugzilla.pm
@@ -61,6 +61,19 @@ use constant SHUTDOWNHTML_EXIT_SILENTLY => [
 # Global Code
 #####################################################################
 
+# The following subroutine is for debugging purposes only.
+# Uncommenting this sub and the $::SIG{__DIE__} trap underneath it will
+# cause any fatal errors to result in a call stack trace to help track
+# down weird errors.
+#
+#sub die_with_dignity {
+#    use Carp ();
+#    my ($err_msg) = @_;
+#    print $err_msg;
+#    Carp::confess($err_msg);
+#}
+#$::SIG{__DIE__} = \&Bugzilla::die_with_dignity;
+
 # Some environment variables are not taint safe
 delete @::ENV{'PATH', 'IFS', 'CDPATH', 'ENV', 'BASH_ENV'};
 

diff --git a/Bugzilla/CGI.pm b/Bugzilla/CGI.pm
index 688878b19ac23485375a571d1df1d153f1d589eb..b4bcf20c8b012e53023c4a3778fc231b9eb84e86 100644 (file)
--- a/Bugzilla/CGI.pm
+++ b/Bugzilla/CGI.pm
@@ -50,18 +50,6 @@ $| = 1;
 $::SIG{TERM} = 'IGNORE';
 $::SIG{PIPE} = 'IGNORE';
 
-# The following subroutine is for debugging purposes only.
-# Uncommenting this sub and the $::SIG{__DIE__} trap underneath it will
-# cause any fatal errors to result in a call stack trace to help track
-# down weird errors.
-#sub die_with_dignity {
-#    use Carp;  # for confess()
-#    my ($err_msg) = @_;
-#    print $err_msg;
-#    confess($err_msg);
-#}
-#$::SIG{__DIE__} = \&die_with_dignity;
-
 # CGI.pm uses AUTOLOAD, but explicitly defines a DESTROY sub.
 # We need to do so, too, otherwise perl dies when the object is destroyed
 # and we don't have a DESTROY method (because CGI.pm's AUTOLOAD will |die|