Add auto LTO option

Add an auto option to named-lto that disables weird setups like clang +
ld.bfd.

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 2f6b58b9a9c5a1ddad16c824d9e4e3ab0e6d8b17..0f3d564ad0a957ad048369b3ec0c98c39663eefc 100644 (file)
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -381,6 +381,7 @@ stages:
       -Ddeveloper=enabled
       -Dleak-detection=enabled
       -Doptimization=1
+      -Dnamed-lto=thin
       $EXTRA_CONFIGURE
       build
 

diff --git a/doc/arm/build.inc.rst b/doc/arm/build.inc.rst
index 0dfaec1ab3b9d4e5322ff5a553132a5ee42fd1ca..9999b89157e86e09f2149c888244c8cf4cddeeac 100644 (file)
--- a/doc/arm/build.inc.rst
+++ b/doc/arm/build.inc.rst
@@ -89,9 +89,11 @@ required when in use.
 
 To further improve performance, compilation with link-time optimization is
 recommended. This is enabled by default via the ``-Dnamed-lto`` option
-(default: ``thin``). Link-time optimization can be disabled if needed by
-using ``-Dnamed-lto=off``. The optimization level can be controlled with
-``-Dnamed-lto=thin`` or ``-Dnamed-lto=full``.
+(default: ``auto``). Link-time optimization can be disabled if needed by
+using ``-Dnamed-lto=disabled``. The optimization level can be controlled with
+``-Dnamed-lto=thin`` or ``-Dnamed-lto=full``. The ``auto`` option enables
+thin LTO when supported by the compiler and linker combination, and disables
+LTO otherwise.
 
 Link-time optimization requires close coordination between the compiler and
 the linker. Due to ``clang`` limitations, compiling ``named`` with ``clang``

diff --git a/meson.build b/meson.build
index 199f1a2c650071c764b792d8ad3265642eb2ed28..cb7a6e2620ea88ff5588cccf2673ed15281f42ac 100644 (file)
--- a/meson.build
+++ b/meson.build
@@ -933,27 +933,48 @@ supported_clang_lto_linkers = [
     'ld.mold',
 ]
 
-# On Mac OS, the has_argument check returns true, but compilation fails, so we
-# simply disable LTO.
-has_fat_lto = cc.has_argument('-ffat-lto-objects') and host_machine.system() != 'darwin'
-if not has_fat_lto
-    warning(
-        'Your platform does not support fat lto objects but -Dnamed-lto was not set to `disabled`. Building without LTO anyway.',
-    )
-    named_lto_opt = 'disabled'
+is_darwin = host_machine.system() == 'darwin'
+is_auto_lto = named_lto_opt == 'auto'
+is_supported_linker = cc.get_linker_id() in supported_clang_lto_linkers
+has_fat_lto = cc.has_argument('-ffat-lto-objects') and not is_darwin
+has_fuzzing_backend = fuzzing_backend_opt != 'none'
+
+# First, resolution of the 'auto' case for LTO.
+if is_auto_lto
+    if has_fuzzing_backend
+        # Fuzzers might need sanitizer converage sections, which LTO discards.
+        # Disable LTO when a fuzzing backend is configured.
+        # NB: enabling -Dfuzzing is fine since it justs builds the binaries.
+        named_lto_opt = 'disabled'
+    elif is_darwin
+        # On Mac OS, the has_argument('-ffat-lto-objects') check returns true,
+        # but compilation fails, so we simply disable LTO.
+        named_lto_opt = 'disabled'
+    elif not has_fat_lto
+        # Some very old compilers don't support fat lto objects.
+        named_lto_opt = 'disabled'
+    elif cc.get_id() == 'clang' and not is_supported_linker
+        # Per LLVM docs [1], -ffat-lto-objects is supported only with lld and gold,
+        # and gold is deprecated/unmantained. Manual testing shows that mold
+        # works too though.
+        named_lto_opt = 'disabled'
+    elif get_option('auto_features').disabled()
+        # Fake being a boolean option for the purpose of -Dauto-features
+        named_lto_opt = 'disabled'
+    else
+        named_lto_opt = 'thin'
+    endif
 endif
 
 static_lto_c_args = []
 static_lto_link_args = []
 
-if named_lto_opt == 'full'
+if developer_mode and is_auto_lto
+    # Build a static `named` but do not enable -flto to improve compilation speed.
+elif named_lto_opt == 'full'
     static_lto_c_args = ['-ffat-lto-objects', '-flto']
     static_lto_link_args = ['-flto']
-elif named_lto_opt == 'thin' and cc.get_id() == 'clang' and cc.get_linker_id() in supported_clang_lto_linkers
-    # Per LLVM docs [1], -ffat-lto-objects is supported only with lld and gold,
-    # and gold is deprecated/unmantained.
-    # [1]: https://llvm.org/docs/FatLTO.html
-
+elif named_lto_opt == 'thin' and cc.get_id() == 'clang' and is_supported_linker
     static_lto_c_args = ['-ffat-lto-objects', '-flto=thin']
     static_lto_link_args = ['-flto=thin']
 elif named_lto_opt == 'thin' and cc.get_id() == 'gcc'

diff --git a/meson.options b/meson.options
index 73f70be303792459e60977587f64436bf3a53cdb..ca0d2fc6e11333f9422f89e2390fe753bef36468 100644 (file)
--- a/meson.options
+++ b/meson.options
@@ -199,7 +199,7 @@ option(
 option(
     'named-lto',
     type: 'combo',
-    choices: ['disabled', 'thin', 'full'],
-    value: 'thin',
+    choices: ['disabled', 'auto', 'thin', 'full'],
+    value: 'auto',
     description: 'Enable Link Time Optimization for named.',
 )