vfs_snapper: free dbus req messages in error paths

Bug: https://bugzilla.samba.org/show_bug.cgi?id=11055

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit f72fa6390b73f47a57033282335786c24664a3f8)

diff --git a/source3/modules/vfs_snapper.c b/source3/modules/vfs_snapper.c
index 12a3b9a16eb2fed00e49efc40ab18472df8881a1..ed6e0737647b5ecf58e18d232a7045fe58e88282 100644 (file)
--- a/source3/modules/vfs_snapper.c
+++ b/source3/modules/vfs_snapper.c
@@ -472,6 +472,7 @@ static NTSTATUS snapper_list_snaps_pack(char *snapper_conf,
        dbus_message_iter_init_append(msg, &args);
        if (!dbus_message_iter_append_basic(&args, DBUS_TYPE_STRING,
                                            &snapper_conf)) {
+               dbus_message_unref(msg);
                return NT_STATUS_NO_MEMORY;
        }
 
@@ -690,16 +691,19 @@ static NTSTATUS snapper_list_snaps_at_time_pack(const char *snapper_conf,
        dbus_message_iter_init_append(msg, &args);
        if (!dbus_message_iter_append_basic(&args, DBUS_TYPE_STRING,
                                            &snapper_conf)) {
+               dbus_message_unref(msg);
                return NT_STATUS_NO_MEMORY;
        }
 
        if (!dbus_message_iter_append_basic(&args, DBUS_TYPE_INT64,
                                            &time_lower)) {
+               dbus_message_unref(msg);
                return NT_STATUS_NO_MEMORY;
        }
 
        if (!dbus_message_iter_append_basic(&args, DBUS_TYPE_INT64,
                                            &time_upper)) {
+               dbus_message_unref(msg);
                return NT_STATUS_NO_MEMORY;
        }