]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bng_en: fix misleading error message for generic firmware version
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Mon, 2 Feb 2026 03:38:43 +0000 (19:38 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 4 Feb 2026 03:11:29 +0000 (19:11 -0800)
The devlink info_get handler incorrectly reports "roce firmware" when
populating the generic firmware version field.

Update the error message to correctly describe the failing operation.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Vikas Gupta <vikas.gupta@broadcom.com>
Link: https://patch.msgid.link/20260202033848.22993-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnge/bnge_devlink.c

index a987afebd64dda918c0b3801e977e20aa719ee96..f3a984d4d5f155743d8766fab8fd67800009f4a6 100644 (file)
@@ -221,7 +221,7 @@ static int bnge_devlink_info_get(struct devlink *devlink,
                              DEVLINK_INFO_VERSION_GENERIC_FW, buf);
        if (rc) {
                NL_SET_ERR_MSG_MOD(extack,
-                                  "Failed to set roce firmware version");
+                                  "Failed to set firmware version");
                return rc;
        }